Modern commemorative/bullion coins can be a profit situation for collectors depending on popularity, timing, precious metals prices. Dealers are obviously making money selling them.
Someone may have compiled price history of commemorative coins the last 30+ years to compare gains/losses and has charts. PCGS
started in 1986. I assume they researched prices back in time to 1970 to begin their PCGS
3000 index. It shows classic/rare coins prices. This index has had good gains. Some may be suspicious of this index, but it provides insight into the coin market over time. I did some calculating, generally, roughly, according to sources I looked at Google searches.
Since 1970 PCGS
3000 has gone up about 5,939%
Since 1970 Dow Jones Ind. has gone up about 4,100%
Since 1970 S&P 500 has gone up about 4,800%
Since 1970 silver $1.63 oz,has gone up about 1,380%
Since 1970 gold $37.38 oz has gone up about 4,700%
The coin market can go up/down like stocks. The highest PCGS
3000 ever got was 1989 at $181,088. It's currently $60,398. If you would have bought every PCGS
3000 coin in 1989 they would now be worth 66.65% less, bad timing.
I can't afford high dollar classic/rare coins. I'm not in the PCGS
3000 arena. I still enjoy my modern coins and my ancient coins. I don't worry much if they appreciate in value. I just try to buy at current fair prices.