What Is A Good Camera To Take Pics Of Coins?

Instead of pointing to a particular brand I'm going to list some capabilities that a "good" camera for imaging coins must have:
-- macro capable
-- adjustable white balance option
-- 8 Megapixels or more
-- capable of being attached to a stable mount
Many inexpensive cameras have these capabilities (notice I didn't say cheap).

Nice options:
-- AC Adapter
-- 1 GB (or larger) memory cards (note the plural)
-- remote shutter release
-- photo editing software
-- camera stand or tripod

Lighting will probably turn out to be your worst initial problem.
White balance can correct for most lighting types.
But number, brightness and positioning will have to be experimented with.
And everything changes from one coining metal to another AND the toning and reflectivity of the coin.

I've been doing this for 5+ years and just decided that I still don't have it right

Hang here, read some of the older threads and you will see images shot with a point&shoot handheld that are better than anything most people can achieve with a $2000 custom built rig. It's all skill, not equipment.

That said... decide if you are going to 'share'. If you are going to use one camera for multiple purposes your needs are different vs. a dedicated unit.

For example - Image Stabilization. Canon (to stay with what I know, vs. a specific recommendation) makes a wonderful macro lens in two configurations - with and without Image Stabilization. If I had planned to use it for other than coin work, I would have considered the $400 (list) additional price of the IS lens. If I had planned to use it just for coin work, I would have considered the cheaper lens without IS.

The reason I bring this up is that whichever line you choose (and all of them have reasons for and against) most of the newer, expensive, bells and whistles aren't needed for macro work. Again with what I know, both the Canon T3i and the T5i have the same 18MP sensor. But the newer unit has an improved digital processor chip. Better images in low light, faster continuous shooting. All things that don't benefit macro work.

But ultimately, it's not the equipment it's the skill of the photographer. Skill that develops only by shooting pictures and figuring out what works and what doesn't work.

You can build a respectable system (especially if you have a little mechanical skill) for under $400. You can also build a custom $2000 rig - and, btw, if you hang here & tell us you have $2k to spend, we'll spend it for you

SLR, decent macro lens, couple of lights, copystand and a StackShot, plus a computer with enough storage to hold the 25MB raw images, software to stack the photos...

as always great advice thank you all

The relationship between budget and quality is linear.

Seriously, though, better first to define what you want your camera to do for you and how much you want to spend on it. Anything from (possibly) the cellphone in your pocket to a personal investment of about $400 is possible, and we can come up with pretty good compromises all along that range. An iPhone is a serious weapon for a coin photographer, believe it or not. The qualitative difference between $25 and $250 out-of-pocket won't be huge, but above that number (it's an estimate) it becomes a whole lot easier to get good images over ranges of magnification.

So we'll start with, what do you already have to play with?