US Proof Dollar Commemortives - Bad Investment?

Short answer...yes. Those are not "investment" items, IMO. The price of silver may one day get you out at a profit though.

any coin is not really something I would call a good investment. There aren't very many coins that will make money over time unless you got the coin for face value when they circulated and they are made of precious metal. There are a few exceptions on super rare and super high grade coins (in this case I am talking about classics not modern coins) where you can expect to make some money even if you turn around and resell the next day because of their rarity there are usually people waiting in line to purchase such coins at just about any price. Even in these circumstances it would be hard to pay triple the coins is worth (like the mint charges) and then turn around and sell it even a few years later for a profit. That is why you should buy what you like and if the value of those coins go up in value that is fine, if they don't then you still enjoy looking at them. There are many other things that have better returns than coins ever have and if you want to invest I would suggest one of those instead of coins

The mint has gone overboard with commemoratives. Just too many, too many types, etc. They're starting to do it with standard releases too.

If it were a rarity thing, commemoratives would be super expensive as most have low mintages and some have super low mintages.

I can't see buying the commemoratives directly from the mint. You can usually find the raw coins slightly above melt value. I am not sure there will ever be the same collectibility of these as they never circulated like the classics. However they are beautiful and I like them more and more every time I look at them.

My principle reason for buying the modern commemorative silver dollar coins (post 1982) was to give my son a sound inflation proof investment for the future. I assumed that their value would continue to increase; and it did, for awhile. Now, however, with silver plunging back down into the $26 dollar/oz range, some commemoratives are selling in the low $20's which surprised me. The Lincoln silver commemorative that only two years ago had jumped up to nearly $80 has dropped to less than half that amount (not slabbed). Even the proof coins versus the uncirculated have fallen below the price the mint sold them for in many cases (93 Madison and others), disappointing.